Etymology debate aside…
Im a producer, I play drums, guitar, banjo and keys…
What makes a good broken beat? Same thing that makes a good straight beat. Timing. Knowing when to put a beat down and knowing where to put it. There is no manual that will tell you how to do it.
I was taught to master modifying the tresillio, and then to explore ghost notes.